Clean-up: sessiond: use empty() instead of comparing size to 0

Harmonize the project's coding style a little by favoring the use of the 'empty()' methood of containers rather than comparing their size to 0. Signed-off-by: Jérémie Galarneau <[email protected]> Change-Id: I22e6b7fe4d94d8f43362fe119b4ca6d480587291
lttng · Mar 12, 2024 · 20c4b46 · 20c4b46
1 parent d83ba9b
commit 20c4b46
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/src/bin/lttng-sessiond/ctf2-trace-class-visitor.cpp b/src/bin/lttng-sessiond/ctf2-trace-class-visitor.cpp
@@ -165,7 +165,7 @@ class field_visitor : public lttng::sessiond::trace::field_visitor,
  _fragment["alignment"] = type.alignment;
  _fragment["preferred-display-base"] = (unsigned int) type.base_;
 
- if (type.roles_.size() > 0) {
+ if (!type.roles_.empty()) {
  json::json role_array = json::json::array();
 
  for (const auto role : type.roles_) {
@@ -201,7 +201,7 @@ class field_visitor : public lttng::sessiond::trace::field_visitor,
  _fragment["alignment"] = type.alignment;
  _fragment["preferred-display-base"] = (unsigned int) type.base_;
 
- if (type.roles_.size() > 0) {
+ if (!type.roles_.empty()) {
  if (std::is_signed<typename EnumerationType::mapping::range_t::
  range_integer_t>::value) {
  LTTNG_THROW_ERROR(
@@ -278,7 +278,7 @@ class field_visitor : public lttng::sessiond::trace::field_visitor,
  _fragment["type"] = "static-length-blob";
  _fragment["length"] = type.length_bytes;
 
- if (type.roles_.size() > 0) {
+ if (!type.roles_.empty()) {
  auto role_array = json::json::array();
 
  for (const auto role : type.roles_) {

diff --git a/src/bin/lttng-sessiond/tsdl-trace-class-visitor.cpp b/src/bin/lttng-sessiond/tsdl-trace-class-visitor.cpp
@@ -566,7 +566,7 @@ class tsdl_field_visitor : public lttng::sessiond::trace::field_visitor,
  void visit(const lst::static_length_array_type& type) final
  {
  if (type.alignment != 0) {
- LTTNG_ASSERT(_current_field_name.size() > 0);
+ LTTNG_ASSERT(!_current_field_name.empty());
  _description += lttng::format(
  "struct {{ }} align({alignment}) {field_name}_padding;\n",
  fmt::arg("alignment", type.alignment),
@@ -587,7 +587,7 @@ class tsdl_field_visitor : public lttng::sessiond::trace::field_visitor,
  * could wrap nested sequences in structures, which
  * would allow us to express alignment constraints.
  */
- LTTNG_ASSERT(_current_field_name.size() > 0);
+ LTTNG_ASSERT(!_current_field_name.empty());
  _description += lttng::format(
  "struct {{ }} align({alignment}) {field_name}_padding;\n",
  fmt::arg("alignment", type.alignment),
@@ -676,7 +676,7 @@ class tsdl_field_visitor : public lttng::sessiond::trace::field_visitor,
  void visit_variant(const lst::variant_type<MappingIntegerType>& type)
  {
  if (type.alignment != 0) {
- LTTNG_ASSERT(_current_field_name.size() > 0);
+ LTTNG_ASSERT(!_current_field_name.empty());
  _description += lttng::format(
  "struct {{ }} align({alignment}) {field_name}_padding;\n",
  fmt::arg("alignment", type.alignment),