Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for microlens #186

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Add support for microlens #186

wants to merge 6 commits into from

Conversation

lsrcz
Copy link
Owner

@lsrcz lsrcz commented Mar 17, 2024

This pull request adds the necessary constructs, instances, and mrg variants for microlens combinators for using microlens with Grisette.

Copy link

codecov bot commented Mar 17, 2024

Codecov Report

Attention: Patch coverage is 27.10280% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 59.60%. Comparing base (54ef499) to head (37e3544).

Files Patch % Lines
src/Grisette/Core/Data/Class/SafeDivision.hs 0.00% 10 Missing ⚠️
src/Grisette/Core/Data/Class/BitVector.hs 0.00% 6 Missing ⚠️
src/Grisette/Core/Data/Class/GenSym.hs 0.00% 6 Missing ⚠️
src/Grisette/Core/Data/Class/SafeSymShift.hs 0.00% 6 Missing ⚠️
src/Grisette/Core/Data/Class/LogicalOp.hs 0.00% 5 Missing ⚠️
src/Grisette/Core/Data/Class/SOrd.hs 0.00% 5 Missing ⚠️
src/Grisette/Lib/Lens/Micro.hs 83.87% 2 Missing and 3 partials ⚠️
src/Grisette/Core/Control/Monad/UnionM.hs 0.00% 4 Missing ⚠️
src/Grisette/Core/Data/Class/Solvable.hs 0.00% 4 Missing ⚠️
src/Grisette/Core/Data/Class/Mergeable.hs 0.00% 3 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   60.18%   59.60%   -0.59%     
==========================================
  Files          72       76       +4     
  Lines        6146     6255     +109     
  Branches      502      508       +6     
==========================================
+ Hits         3699     3728      +29     
- Misses       1945     2019      +74     
- Partials      502      508       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant