Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse hex colors in themes (#647) #889

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

zappolowski
Copy link
Contributor

@zappolowski zappolowski commented Aug 29, 2023

This fixes the issue described in #647.

crossterm recently learned to deserialize strings of the format #xxxxxx and thus we just need to delegate deserialization of colors to them.


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

I didn't check all TODO items as I'm not sure which of these apply here.

@muniu-bot
Copy link

muniu-bot bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zappolowski

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Just delegate to the default deserializer of crossterm which learned
dealing with hex color in version 0.27.0.
@zwpaper
Copy link
Member

zwpaper commented Aug 30, 2023

hi @zappolowski, Thanks so much for adding this feature!

/kind feature

@muniu-bot muniu-bot bot added the kind/feature New feature request label Aug 30, 2023
@zwpaper zwpaper merged commit 7a9506d into lsd-rs:master Aug 30, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants