fix(plugins/achievements): fix progress of rank A #1430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request seems to be inactive and will be automatically closed in a few days if it remains without any activity. |
Repository owner
unlocked this conversation
Jul 25, 2023
lowlighter
approved these changes
Jul 25, 2023
|
This pull request seems to be inactive and will be automatically closed in a few days if it remains without any activity. |
lowlighter
approved these changes
Aug 25, 2023
|
Sorry I think I forgot to click on the merge button last time 😅 Thanks a lot for this fix ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Just fix a little typo bug in plugins/achievements/index.mjs.
Motivation
The progress of rank A achievements won't show as expected. Because the range is set to
m - a(max - rankA) nots - a(rankS - rankA). Just changemtoscan fix this.Example
Before (next level need 1000, but here already has 822):
After:
