Support page selection for multi-page TIFF #1204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovell
requested changes
Apr 24, 2018
There was a problem hiding this comment.
This is great, thank you Nathan. There's one small comment inline but otherwise LGTM.
I think the error message is OK as it is as that's an underlying libvips error, the likes of which we already expose in many places.
I've created #1205 to track the possible future enhancement to expose page counts in the metadata feature.
Please feel free to add your name to the list of contributors too.
src/common.cc
Outdated
| @@ -229,6 +233,9 @@ namespace sharp { | |||
| if (imageType == ImageType::MAGICK) { | |||
| option->set("density", std::to_string(descriptor->density).data()); | |||
| } | |||
| if (imageType == ImageType::TIFF) { | |||
| option->set("page", static_cast<int>(descriptor->page)); | |||
There was a problem hiding this comment.
Is the static_cast required here (and in the similar code below) given this is already an int?
|
Removed the static_cast and updated contributors. Thanks for the review, and I'll keep an eye on #1205. |
lovell
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based off of #654 with changes requested by @lovell. It adds support for zero-indexed page selection from multi-page TIFF's.
The included test image was generated from the existing G31D.TIF. The second page is a 50% scaled copy of the first page.
The error message for an invalid page index could be more informative. If there is an easy way to determine the TIFF page count with libvips, please let me know. Feedback appreciated. :)