Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore:extracted the group monitor to a different monitoring type #4395

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

CommanderStorm
Copy link
Collaborator

@CommanderStorm CommanderStorm commented Jan 18, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

This PR is part of the migration to monitoring-types.
I migrated the group monitor into a different monitoring type.
No actual code changes have been made, this is just a code move.

Type of change

  • Other

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

previous now
image image

@CommanderStorm CommanderStorm marked this pull request as ready for review January 18, 2024 23:14
@no8ody
Copy link

no8ody commented Jan 19, 2024

Hello,

this PR presumably only affects the backend? Wouldn't it make sense to use this grouping for the frontend as well? As the servers in this group are not currently visible there and the entire group is displayed as "down" if a service fails

@CommanderStorm
Copy link
Collaborator Author

Wouldn't it make sense to use this grouping for the frontend as well?

The existing grouping functionality (see screenshots) was not changed. It is implemented in the frontend.

As the servers in this group are not currently visible there and the entire group is displayed as "down" if a service fails

Currently, groups are down if children.any(child=> child.is_down)

This is tracked in different issues and I decided not to include them to make reviewing eazier.
See these issues:

@CommanderStorm CommanderStorm changed the title extracted the group monitor to a different monitoring type chore:extracted the group monitor to a different monitoring type Jan 20, 2024
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Jan 20, 2024
@CommanderStorm CommanderStorm added this to the 2.1.0 milestone Jan 20, 2024
@CommanderStorm CommanderStorm added the needs:review this PR needs a review by maintainers or other community members label May 19, 2024
@github-actions github-actions bot added needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 19, 2024
@github-actions github-actions bot removed the needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again label May 21, 2024
@github-actions github-actions bot added needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again and removed needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again labels May 22, 2024
@github-actions github-actions bot removed the needs:resolve-merge-conflict A merge-conflict needs to be addressed before reviewing makes sense again label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:monitor Everything related to monitors house keeping needs:review this PR needs a review by maintainers or other community members
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants