Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow Response Monitoring Visual Improvements #4112

Conversation

stephenpapierski
Copy link

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Adds Visual Elements to #4005
Fixes #4035

This pull request generally adds visual flair to the work done in #4005 . Since all changes are visual, change details are listed under screenshots below.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots

  • Add threshold line to ping chart
    • image
  • Add Slow badge to monitor dashboard when service is responding slow (no badge when Nominal)
    • image
  • Add Slow/Nominal entries to events log
    • image
  • Add Slow/Nominal toast messages
    • image
    • image
  • Add number of Slow services to Dashboard Quick Stats
    • image

stephenpapierski and others added 30 commits October 26, 2023 22:40
louislam#1878 with modern
knex_migration
…enpapierski/uptime-kuma into feature-slow-response-notification
@stephenpapierski stephenpapierski marked this pull request as draft November 27, 2023 20:19
@stephenpapierski stephenpapierski marked this pull request as ready for review December 21, 2023 07:31
@stephenpapierski
Copy link
Author

Merged into #4005

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heartbeatList different on page load
1 participant