Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Middleware #1

Merged
merged 5 commits into from
May 9, 2021
Merged

Middleware #1

merged 5 commits into from
May 9, 2021

Conversation

gurgeous
Copy link
Contributor

first pass at listing interesting middleware. (see lostisland/faraday#1270)

Copy link
Member

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super!

One typographic thing I would want us to keep doing: uppercase terms like HTTP and XML, UTF-8 and JSON.

@gurgeous
Copy link
Contributor Author

Sure - how about this?

@gurgeous
Copy link
Contributor Author

gurgeous commented May 5, 2021

Ping, just want to make sure this one is still in the pipeline. There's a link to it now... :)

@olleolleolle
Copy link
Member

One note: the wording "curated list" - does that refer to the built-in Faraday middlewares? We want to convey the idea that they're more "soldered-on" at the moment, more than "finely curated". The next major would like to have fewer middlewares baked-in, so, as a strategic side-step around that, perhaps we can refer to the current set of Faraday gem middlewares as the built-in set?

@olleolleolle
Copy link
Member

I think we should merge this in, and have this big, navigable list available!

@gurgeous
Copy link
Contributor Author

gurgeous commented May 7, 2021

One note: the wording "curated list" - does that refer to the built-in Faraday middlewares? We want to convey the idea that they're more "soldered-on" at the moment, more than "finely curated". The next major would like to have fewer middlewares baked-in, so, as a strategic side-step around that, perhaps we can refer to the current set of Faraday gem middlewares as the built-in set?

My wording was confusing. I was trying to explain that the awesome-faraday repo doesn't list all Faraday middleware. The first version of our "curated list" was mostly determined by searching rubygems.org. Do you think I should re-word this bit?

In addition to our curated list of middleware, we would like to specifically call your attention to middleware that is helpful for general HTTP use...

Maybe:

We would also like to specifically call your attention to middleware that is helpful for general HTTP use...

?

@olleolleolle
Copy link
Member

Aha, then perhaps "this curated list of ..." is a wording which encapsulates that?

@gurgeous
Copy link
Contributor Author

gurgeous commented May 9, 2021

Better?

@olleolleolle olleolleolle merged commit 6fd17c1 into lostisland:main May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants