Fix iconv issue with alpine image #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there 👋 Thanks for your contribution. However, I'm not comfortable merging code that I do not 100% understand. The need for an external repository and a I have no doubt that this fixes your issue but I'm not sure that it's going to be a non-breaking change for other users of this library that might use this container in production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When usign Nuno Maduros insights package for Laravel, the required Nette package does not handle the iconv function properly as discussed here: nunomaduro/phpinsights#43
I tried the solution and created the topredmedia/laravel-docker image on docker hub. The problem is fixed with this PR.