Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to use data-attribute instead of title #3

Merged
merged 2 commits into from
Oct 26, 2013
Merged

Small change to use data-attribute instead of title #3

merged 2 commits into from
Oct 26, 2013

Conversation

lpilon
Copy link

@lpilon lpilon commented May 19, 2013

Removed title as source for image, used data-attribute instead (default
data-photo, configurable by user).

Removed title as source for image, used data-attribute instead (default
data-photo, configurable by user).
@lorenzos
Copy link
Owner

The title attribute was not the source for the image, but the tooltip text content placed below the image (it makes sense). You didn't changed it to use data-photo instead of title, but instead of rel (and it makes sense too).

Additionally I can't get why you removed lines 47 and 48: without them the standard tooltip displayed by browsers is showed together with the one generated by the script, which is not ok. That lines where added in a53ea80 to fix #1.

@lpilon
Copy link
Author

lpilon commented May 20, 2013

Indeed, you are right. Made the changes a few weeks ago and in the hurry I mixed rel and title up.

I see the reason for removing the standard tooltip. In my situation, I’m using the title-text somewhere else; it breaks because the title is empty.

Anyway, I restored it (but also to a data-attribute), and will change my own script to make them play nice.

lorenzos added a commit that referenced this pull request Oct 26, 2013
Small change to use data-attribute instead of title
@lorenzos lorenzos merged commit 024b72e into lorenzos:master Oct 26, 2013
@lorenzos
Copy link
Owner

Merged after a long time, sorry ;) I also renamed the new option and changed its default value in 6cdd451#diff-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants