Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix program crash by removing staticmethod decorator #320

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

0xHanan
Copy link

@0xHanan 0xHanan commented Apr 28, 2022

No description provided.

forsakenquantum and others added 7 commits February 16, 2022 01:10
- download fonts separately from CSS
- scan for img tags with too many width/height specifiers and eliminate redundant ones
The program crash when running with certain IDs (i.e. 9781484258811). The error message is:
`[#] Unhandled Exception: name 'self' is not defined (type: NameError)`

The crash occurs because the static function `fix_overconstrained_images` use `self` . The function can't use self since it's static. By removing the @staticmethod decorator the program successfully complete the download.
@0xHanan 0xHanan changed the title 0x hanan remove staticmethod decorator Fix program crash by removing staticmethod decorator Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants