sso_cookies.py: Parse according to RFC 6265 #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Individual cookies in the `Cookie` header, according to Section 5.4 of RFC 6265 [1], are separated by the "semicolon-space" (`; `) combination. This becomes relevant when there is a cookie whose value contains a semicolon. I have just encountered one on O'Reilly Learning, namely `OptanonConsent` ending in `&geolocation=US;CA`, which was breaking the script. [1]: https://www.rfc-editor.org/rfc/rfc6265#section-5.4
0x6f677548
pushed a commit
to 0x6f677548/safaribooks
that referenced
this pull request
Mar 16, 2023
sso_cookies.py: Parse according to RFC 6265. @left-blank Thank you 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Individual cookies in the
Cookieheader, according to Section 5.4 of RFC 6265,are separated by the "semicolon-space" (
;) combination. This becomes relevantwhen there is a cookie whose value contains a semicolon. I have just encountered one
on O'Reilly Learning, namely
OptanonConsentending in&geolocation=US;CA,which was breaking the script.