Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix images url and remove trailing spaces #288

Merged
merged 5 commits into from
Oct 25, 2021

Conversation

gudata
Copy link
Contributor

@gudata gudata commented Sep 25, 2021

make the images relative to the content rather than to the assets

check 9780596800611 for example

@truongsinh
Copy link

Confirm this one works for me.

Copy link

@ReLLL ReLLL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine, fixes the image issue

@rivman
Copy link

rivman commented Oct 1, 2021

Working perfect so far, many thanks mate for this. Cheers.

@lorenzodifuccia
Copy link
Owner

Hi @gudata, great work!!
Could you please review the suggestion?
I'll merge as soon as you agree with the change!

Thanks 🙏🏻🙏🏻🙏🏻

@lorenzodifuccia lorenzodifuccia linked an issue Oct 7, 2021 that may be closed by this pull request
safaribooks.py Outdated Show resolved Hide resolved
@Bomberdash
Copy link

Good afternoon.
After making these changes, it stopped working at all.
I had to clone the repository again.
Thus, the problem remains:
-part of the books are downloaded WITHOUT images;
-some are downloaded without spaces;
-or there is a download of the text with krakozyabram, although the site opens normally.
Maybe there is already a corrected (ready-made) version?

@Bomberdash
Copy link

The content of my file is very different
When making changes, various errors occur at the start
Therefore, I will repeat the question - is there a ready-made safaribooks.py file?
In which there are already changes in relation to spaces and pictures

@redlegoman
Copy link

redlegoman commented Oct 25, 2021

The content of my file is very different When making changes, various errors occur at the start Therefore, I will repeat the question - is there a ready-made safaribooks.py file? In which there are already changes in relation to spaces and pictures

Your demand can probably be best served by using @gudata's fork until his changes are merged into this one. @gudata's is here : https://github.com/gudata/safaribooks

@lorenzodifuccia lorenzodifuccia merged commit e016ad3 into lorenzodifuccia:master Oct 25, 2021
@lorenzodifuccia
Copy link
Owner

Thank you all ❤️❤️
Let's test it and see if everything works!

0x6f677548 pushed a commit to 0x6f677548/safaribooks that referenced this pull request Mar 16, 2023
fix images url and remove trailing spaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Epub file not include image file
8 participants