Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update safaribooks.py #272

Merged
merged 1 commit into from
Aug 24, 2021

Conversation

regulskimichal
Copy link
Contributor

No description provided.

Copy link
Owner

@lorenzodifuccia lorenzodifuccia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, saw the issue.
Closes #271

@@ -524,7 +524,7 @@ def check_login(self):
elif response.status_code != 200:
self.display.exit("Authentication issue: unable to access profile page.")

elif "user_type\":\"Expired" in response.text:
elif "user_type\":\"Expired\"" in response.text:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why specify the quote in this elif?

@lorenzodifuccia lorenzodifuccia merged commit 38a74b4 into lorenzodifuccia:master Aug 24, 2021
0x6f677548 pushed a commit to 0x6f677548/safaribooks that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants