Issue #237: unhandled exception for missing "rights" key #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also stopped working with the output "right" |
|
Please refer to this: https://github.com/lorenzodifuccia/safaribooks/pull/245/commits Or, you won't be able to generate an "EPUB". |
lorenzodifuccia
approved these changes
Nov 23, 2020
This was referenced Nov 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported issue #237 is caused by unhandled exception thrown for missing key "rights" in the
infoandbook_infodictionaries when fetching book info.This PR addresses above issue by replacing "rights" key lookup to using built-in
getmethod with default value if the key is missing in the dictionary.Similar replacements applied to other keys as well to prevent similar missing key exception.