Properties with underscores in their name cannot be indexed

[ewrayjohnson]

Steps to reproduce

1. create a model with a property name that contains an underscore in it (e.g. short_name).
2. set that property to be indexed (e.g. "index": true)
3. call pg.autoupdate() (e.g. where app.datasources.pg);

Current Behavior

1. The index is added
2. Then the index is dropped

Expected Behavior

1. The index is added

Additional information

The bug shown here is a bad regular expression in migration.js (on or about line 777):
const propNameRegEx = new RegExp('^' + self.table(model) + '_([^_]+)_idx');

The simple fix is:
const propNameRegEx = new RegExp('^' + self.table(model) + '_(.*)(?:_idx)$');

[dhmlau]

@ewrayjohnson, would you be interested to submit a PR?

[dhmlau]

A workaround would be to specify a "valid" column name in the @property decorator. See https://github.com/dhmlau/loopback4-example-todo-customized#if-i-have-a-table-name-or-column-name-that-is-different-from-the-model-name-and-property-what-should-i-change for an example. Thanks.

[ewrayjohnson]

A workaround would be to specify a "valid" column name in the @property decorator. See https://github.com/dhmlau/loopback4-example-todo-customized#if-i-have-a-table-name-or-column-name-that-is-different-from-the-model-name-and-property-what-should-i-change for an example. Thanks.

[ewrayjohnson]

For those of us that have not taken the leap to LoopBack 4, the @Property decorator is not an option. Instead we would have to use postgresql.columnName

[ewrayjohnson]

@ewrayjohnson, would you be interested to submit a PR?

Yes

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.