Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: query to fetch unique columns #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: query to fetch unique columns #580

wants to merge 1 commit into from

Conversation

aaqilniz
Copy link
Contributor

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@aaqilniz aaqilniz marked this pull request as ready for review June 25, 2024 08:12
samarpanB
samarpanB reviewed Jul 11, 2024
View reviewed changes
lib/discovery.js
* @param table
* @returns {string}
*/
MySQL.prototype.buildQueryUniqueKeys = function(schema, table) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we write a test case for this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpanB samarpanB samarpanB left review comments

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

@marioestradarosa marioestradarosa Awaiting requested review from marioestradarosa marioestradarosa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aaqilniz @samarpanB