Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update environment #668

Open
wants to merge 3 commits into
base: 5.x
Choose a base branch
from
Open

ci: update environment #668

wants to merge 3 commits into from

Conversation

achrinza
Copy link
Member

@achrinza achrinza commented Apr 19, 2022

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

Pull Request Test Coverage Report for Build 173

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.007%

Totals Coverage Status
Change from base Build 78: 0.0%
Covered Lines: 913
Relevant Lines: 1061

💛 - Coveralls

@achrinza achrinza added the v5.x Affects v5.x label Apr 20, 2022
@achrinza achrinza force-pushed the ci/node18-v5.x branch 2 times, most recently from 30a3f10 to 71e86b9 Compare April 20, 2022 14:31
@achrinza achrinza changed the title ci: test against Node.js v18 ci: update environment Apr 20, 2022
- Test against MongoDB v3.6 and v5.0
- fix Travis CI config
- Use `npm ci --ignore-scripts`

Signed-off-by: Rifa Achrinza <[email protected]>
Signed-off-by: Rifa Achrinza <[email protected]>
@achrinza achrinza force-pushed the ci/node18-v5.x branch 2 times, most recently from 22b1eab to 0659b3e Compare April 20, 2022 14:49
@achrinza achrinza marked this pull request as ready for review April 20, 2022 15:04
@achrinza achrinza requested a review from dhmlau as a code owner April 20, 2022 15:04
@@ -16,7 +16,8 @@ jobs:
strategy:
matrix:
node-version: [10, 12, 14]
mongodb-version: [4.4] # the latest stable version
mongodb-version: [3.6, 4.4, 5.0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

according to https://www.mongodb.com/support-policy/lifecycles, mongodb v3.6 has reached EOL last April. Do we still want to include that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since connector 5.x was released when MongoDB 3.x was still supported, I wanted to make sure it still works with that version (i.e. Dropping a MongoDB version should require a semver major on the connector as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v5.x Affects v5.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants