Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1628: Gradle not working in Mac OS JDK10 #1629

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

sakshee-19
Copy link
Contributor

Short description

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

Fixes: #1628

@codecov-io
Copy link

codecov-io commented Sep 21, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@f7eb47b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             development   #1629   +/-   ##
=============================================
  Coverage               ?   9.78%           
  Complexity             ?     461           
=============================================
  Files                  ?     211           
  Lines                  ?   19427           
  Branches               ?    3578           
=============================================
  Hits                   ?    1901           
  Misses                 ?   17185           
  Partials               ?     341

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7eb47b...310a9f3. Read the comment docs.

@sakshee-19
Copy link
Contributor Author

@singhpratyush @simsausaurabh @Orbiter please review.

Copy link
Member

@simsausaurabh simsausaurabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sakshee-19 LGTM 👍

@singhpratyush @Orbiter Please provide your views too.

@singhpratyush
Copy link
Member

Thanks for the code. Could you please clarify how this would resolve the issue?

@sakshee-19
Copy link
Contributor Author

@singhpratyush JaCoCo was failing to start when another agent used UUID prior to JaCoCo. I found its solution on the web: jacoco/jacoco#551, and other sources. Upgrading which helped me in fixing this issue and now tests execute fine on Mac OS too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants