Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1583: Add test for GeoLocation.java #1584

Merged
merged 1 commit into from
Apr 29, 2018

Conversation

simsausaurabh
Copy link
Member

Short description

I have:

  • There is a corresponding issue for this pull request.
  • Mentioned the Issue number in the pull request commit message Fixes #<number> commit message
  • There is only strictly only one commit per issue.

For the reviewers

I have:

  • Reviewed this pull request by an authorized contributor.
  • The reviewer is assigned to the pull request.

Fixes: #1583

@codecov-io
Copy link

codecov-io commented Apr 28, 2018

Codecov Report

❗ No coverage uploaded for pull request base (development@419476d). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             development   #1584   +/-   ##
=============================================
  Coverage               ?    9.7%           
  Complexity             ?     462           
=============================================
  Files                  ?     210           
  Lines                  ?   19279           
  Branches               ?    3541           
=============================================
  Hits                   ?    1871           
  Misses                 ?   17078           
  Partials               ?     330

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419476d...30549e9. Read the comment docs.

@simsausaurabh
Copy link
Member Author

@singhpratyush please review.

public void geoLocation() {

Collection<String> names = new ArrayList<String>();
names.add("Indian Institute of Information Technology Vadodara");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please go with something that is more static/known such as some popular historical monument. The tests are supposed to be running independent of changes in entities not a part of the project.

@simsausaurabh
Copy link
Member Author

@singhpratyush please review.

@singhpratyush singhpratyush merged commit c8cdbd2 into loklak:development Apr 29, 2018
@simsausaurabh simsausaurabh deleted the working branch April 29, 2018 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants