Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from javax package to jakarta #36

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

kdombeck
Copy link
Contributor

This issue was a long time in the making.

This PR upgrades to Guice 7.0

@kdombeck
Copy link
Contributor Author

@ofir-popowski Is there a possibility of having this reviewed and merged?

Thank you

@kdombeck
Copy link
Contributor Author

kdombeck commented Aug 4, 2023

@ofir-popowski would you be able to look at this PR? thanks

Copy link
Contributor

@ofir-popowski ofir-popowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kdombeck Thank you very much for this, and I apologize for the late reply 🙏🏻
I'm going to (try to) merge and cut a release from this

I should point out that we're not actively maintaining this library anymore. I will see about making you a maintainer or collaborator on this repository (if you're interested)

@ofir-popowski ofir-popowski merged commit dd41d2c into logzio:master Aug 7, 2023
1 check passed
@kdombeck kdombeck deleted the javax-to-jakarta branch August 7, 2023 13:32
@kdombeck
Copy link
Contributor Author

kdombeck commented Aug 7, 2023

@ofir-popowski thank you so much!!

I will gladly be a maintainer/collaborator. Let me know what I need to do.

@ofir-popowski
Copy link
Contributor

@kdombeck okay so here's the thing, as mentioned before we are not maintaining this library at all, and have deprecated it internally in our organization. Additionally, I'm sorry to say we cannot accept members / collaborators to our OS projects at this time

So we have 2 options

  1. We can keep what we have done so far. You can keep submitting PRs and we'll review and cut release when we have some time
  2. You can fork this and maintain it independently (changing the group id away from io.logz), and setup publishing to a central repository. We will update the README in this repository to point to your fork and note this one as deprecated / unmaintained

Please let me know which of those you find agreeable, and I'd like to thank you for all of your contributions so far :)

@kdombeck
Copy link
Contributor Author

kdombeck commented Aug 7, 2023

I'm fine with option 1. Since this is the repo that shows up in Google search results.

I can take any issues or PRs that other people submit to this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants