Allow HttpConfiguration to Jetty server #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asafalima
approved these changes
Mar 15, 2021
asafm
suggested changes
Mar 15, 2021
| @@ -53,7 +54,7 @@ public void stop() throws Exception { | |||
| private void configureServer() { | |||
| List<ServerConnectorConfiguration> serverConnectorConfigurations = jerseyConfiguration.getServerConnectors(); | |||
| serverConnectorConfigurations.forEach(configuration -> { | |||
| ServerConnector connector = new ServerConnector(server); | |||
| ServerConnector connector = new ServerConnector(server, new HttpConnectionFactory(configuration.getHttpConfiguration())); | |||
There was a problem hiding this comment.
let's do this like the rest:
connector.setConnectionFactories(new HttpConnectionFactory(configuration.getHttpConfiguration()))
| @@ -38,6 +39,11 @@ public JerseyConfigurationBuilder addPort(int port) { | |||
| return this; | |||
| } | |||
|
|
|||
| public JerseyConfigurationBuilder addPortWithHttpConfiguration(int port, HttpConfiguration httpConfiguration) { | |||
There was a problem hiding this comment.
It's too many flavors. Let's create a ServerConnectorConfigurationBuilder and do this right
| @@ -38,7 +39,7 @@ public static void createServerAndTest(JerseyConfigurationBuilder configurationB | |||
| JettyServerCreator jettyServerCreator, | |||
| Tester tester) throws Exception { | |||
| int port = FreePortFinder.findFreeLocalPort(); | |||
| configurationBuilder.addPort(port); | |||
| configurationBuilder.addPortWithHttpConfiguration(port, new HttpConfiguration()); | |||
There was a problem hiding this comment.
Let's add a small test that shows I configure jetty with it and it works. Max request header sounds about right
asafm
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.