Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): implement verification code verification API #6001

Open
wants to merge 3 commits into
base: simeng-log-9035-core-interaction-class
Choose a base branch
from

Conversation

simeng-li
Copy link
Contributor

@simeng-li simeng-li commented Jun 7, 2024

Summary

Implement the code verification API.

Including:

  • send verification code API
  • verify verification code API
  • code verification class

Add integration test cases for the verification code APIs using both phone and email.

Testing

Integration test added

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Jun 7, 2024

COMPARE TO master

Total Size Diff ⚠️ 📈 +41.27 KB

Diff by File
Name Diff
packages/core/src/routes/experience/classes/interaction-session.ts 📈 +5.89 KB
packages/core/src/routes/experience/classes/verifications/code-verification.ts 📈 +6.33 KB
packages/core/src/routes/experience/classes/verifications/index.ts 📈 +1.13 KB
packages/core/src/routes/experience/classes/verifications/password-verification.ts 📈 +2.79 KB
packages/core/src/routes/experience/classes/verifications/verification.ts 📈 +416 Bytes
packages/core/src/routes/experience/const.ts 📈 +256 Bytes
packages/core/src/routes/experience/index.ts 📈 +2.77 KB
packages/core/src/routes/experience/middleware/koa-interaction-session.ts 📈 +1.1 KB
packages/core/src/routes/experience/type.ts 📈 +123 Bytes
packages/core/src/routes/experience/utils.ts 📈 +442 Bytes
packages/core/src/routes/experience/verification-routes/password-verification.ts 📈 +1.44 KB
packages/core/src/routes/experience/verification-routes/verification-code.ts 📈 +2.81 KB
packages/core/src/routes/init.ts 📈 +254 Bytes
packages/core/src/routes/interaction/utils/interaction.ts 📈 +98 Bytes
packages/integration-tests/src/api/experience-api/const.ts 📈 +237 Bytes
packages/integration-tests/src/api/experience-api/index.ts 📈 +599 Bytes
packages/integration-tests/src/api/experience-api/password-verification.ts 📈 +500 Bytes
packages/integration-tests/src/api/experience-api/verification-code.ts 📈 +893 Bytes
packages/integration-tests/src/client/index.ts 📈 +172 Bytes
packages/integration-tests/src/helpers/experience/index.ts 📈 +1.81 KB
packages/integration-tests/src/helpers/experience/verification-code.ts 📈 +1.24 KB
packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/password.test.ts 📈 +1.19 KB
packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/verification-code.test.ts 📈 +1.14 KB
packages/integration-tests/src/tests/api/experience-api/verifications-api/password-verification.test.ts 📈 +1.27 KB
packages/integration-tests/src/tests/api/experience-api/verifications-api/verification-code.test.ts 📈 +4.37 KB
packages/schemas/src/types/interactions.ts 📈 +2.08 KB

@github-actions github-actions bot added the size/s label Jun 7, 2024
@simeng-li simeng-li changed the title Simeng log 9108 sign in with verification code feat(core): implement sign-in with verification code flow Jun 11, 2024
@simeng-li simeng-li changed the title feat(core): implement sign-in with verification code flow feat(core): implement sign-in with verification code flow Jun 12, 2024
@github-actions github-actions bot added the feature Cool stuff label Jun 12, 2024
@github-actions github-actions bot added size/l and removed size/s labels Jun 20, 2024
@simeng-li simeng-li requested review from a team, wangsijie and charIeszhao and removed request for a team June 20, 2024 10:38
@simeng-li simeng-li marked this pull request as ready for review June 20, 2024 10:38
@simeng-li simeng-li requested a review from gao-sun as a code owner June 20, 2024 10:38
@simeng-li simeng-li force-pushed the simeng-log-9108-sign-in-with-verification-code branch from 5d2d15b to 7128c6b Compare June 21, 2024 08:17
@simeng-li simeng-li changed the base branch from simeng-log-9045-post-verificationverification-code to simeng-log-9035-core-interaction-class June 21, 2024 08:17
@github-actions github-actions bot added size/xl and removed size/l labels Jun 21, 2024
@simeng-li simeng-li changed the title feat(core): implement sign-in with verification code flow feat(core): implement verification code verification API Jun 21, 2024
@simeng-li simeng-li force-pushed the simeng-log-9035-core-interaction-class branch from 6971e1a to 6e4faeb Compare June 21, 2024 09:11
@simeng-li simeng-li force-pushed the simeng-log-9108-sign-in-with-verification-code branch from 8ee8685 to bcc4336 Compare June 21, 2024 09:12
@simeng-li simeng-li force-pushed the simeng-log-9035-core-interaction-class branch from 6e4faeb to 9a93118 Compare June 24, 2024 03:23
@simeng-li simeng-li force-pushed the simeng-log-9108-sign-in-with-verification-code branch 2 times, most recently from 8c66afe to f306a1d Compare June 25, 2024 02:55
@simeng-li simeng-li force-pushed the simeng-log-9035-core-interaction-class branch from a6a918e to 315ee2d Compare June 26, 2024 09:59
@simeng-li simeng-li force-pushed the simeng-log-9108-sign-in-with-verification-code branch 2 times, most recently from 5b793de to 0d8643d Compare June 26, 2024 11:07
…cture

refactor using the latest experience api structure
@simeng-li simeng-li force-pushed the simeng-log-9108-sign-in-with-verification-code branch from 0d8643d to 64ca1fb Compare June 26, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants