-
-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): implement verification code verification API #6001
Open
simeng-li
wants to merge
3
commits into
simeng-log-9035-core-interaction-class
Choose a base branch
from
simeng-log-9108-sign-in-with-verification-code
base: simeng-log-9035-core-interaction-class
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): implement verification code verification API #6001
simeng-li
wants to merge
3
commits into
simeng-log-9035-core-interaction-class
from
simeng-log-9108-sign-in-with-verification-code
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
Name | Diff |
---|---|
packages/core/src/routes/experience/classes/interaction-session.ts | 📈 +5.89 KB |
packages/core/src/routes/experience/classes/verifications/code-verification.ts | 📈 +6.33 KB |
packages/core/src/routes/experience/classes/verifications/index.ts | 📈 +1.13 KB |
packages/core/src/routes/experience/classes/verifications/password-verification.ts | 📈 +2.79 KB |
packages/core/src/routes/experience/classes/verifications/verification.ts | 📈 +416 Bytes |
packages/core/src/routes/experience/const.ts | 📈 +256 Bytes |
packages/core/src/routes/experience/index.ts | 📈 +2.77 KB |
packages/core/src/routes/experience/middleware/koa-interaction-session.ts | 📈 +1.1 KB |
packages/core/src/routes/experience/type.ts | 📈 +123 Bytes |
packages/core/src/routes/experience/utils.ts | 📈 +442 Bytes |
packages/core/src/routes/experience/verification-routes/password-verification.ts | 📈 +1.44 KB |
packages/core/src/routes/experience/verification-routes/verification-code.ts | 📈 +2.81 KB |
packages/core/src/routes/init.ts | 📈 +254 Bytes |
packages/core/src/routes/interaction/utils/interaction.ts | 📈 +98 Bytes |
packages/integration-tests/src/api/experience-api/const.ts | 📈 +237 Bytes |
packages/integration-tests/src/api/experience-api/index.ts | 📈 +599 Bytes |
packages/integration-tests/src/api/experience-api/password-verification.ts | 📈 +500 Bytes |
packages/integration-tests/src/api/experience-api/verification-code.ts | 📈 +893 Bytes |
packages/integration-tests/src/client/index.ts | 📈 +172 Bytes |
packages/integration-tests/src/helpers/experience/index.ts | 📈 +1.81 KB |
packages/integration-tests/src/helpers/experience/verification-code.ts | 📈 +1.24 KB |
packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/password.test.ts | 📈 +1.19 KB |
packages/integration-tests/src/tests/api/experience-api/sign-in-interaction/verification-code.test.ts | 📈 +1.14 KB |
packages/integration-tests/src/tests/api/experience-api/verifications-api/password-verification.test.ts | 📈 +1.27 KB |
packages/integration-tests/src/tests/api/experience-api/verifications-api/verification-code.test.ts | 📈 +4.37 KB |
packages/schemas/src/types/interactions.ts | 📈 +2.08 KB |
wangsijie
approved these changes
Jun 21, 2024
5d2d15b
to
7128c6b
Compare
6971e1a
to
6e4faeb
Compare
8ee8685
to
bcc4336
Compare
6e4faeb
to
9a93118
Compare
8c66afe
to
f306a1d
Compare
a6a918e
to
315ee2d
Compare
5b793de
to
0d8643d
Compare
…cture refactor using the latest experience api structure
update some comments
rebase the core interaction apis change
0d8643d
to
64ca1fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement the code verification API.
Including:
Add integration test cases for the verification code APIs using both phone and email.
Testing
Integration test added
Checklist
.changeset