configure --with-default-mail-command-path: specify default mail command #100
Conversation
schaal
force-pushed
the
mailcommand
branch
2 times, most recently
from
f842d0a
to
c77d2e7
Compare
| and mail it to the recipient. The default mail command is \fB/bin/mail | ||
| -s\fR. | ||
| and mail it to the recipient. The default mail command is shown in the | ||
| output from \fBlogrotate --help\fR. | ||
|
|
There was a problem hiding this comment.
clever. however this is .in file, so @DEFAULT_MAIL_COMMAND@ should be available as autoconf substitution.
There was a problem hiding this comment.
I tried to keep the current definitions from config.h if configure is called without this option, but then @DEFAULT_MAIL_COMMAND@ is not available in autoconf
There was a problem hiding this comment.
ok then by me. ideally the config.h platform defaults should be moved to configure or dropped at all.
| @@ -64,6 +64,22 @@ AC_ARG_WITH([state-file-path], | |||
| AC_DEFINE_UNQUOTED([STATEFILE], "$STATE_FILE_PATH") | |||
| AC_SUBST(STATE_FILE_PATH) | |||
|
|
|||
| AC_ARG_WITH([default-mail-command-path], | |||
| AC_HELP_STRING([--with-default-mail-command-path=PATH], | |||
| [path to default mail command (based on config.h if not given)]), | |||
There was a problem hiding this comment.
it is not "path", but "command", i.e the default value is "path" + "arguments": /bin/mail -s, so --with-default-mail-command would be more appropriate.
There was a problem hiding this comment.
Right, makes more sense, will update with your suggestion
schaal
force-pushed
the
mailcommand
branch
2 times, most recently
from
e2bdf7d
to
fb9769d
Compare
|
On Monday, January 02, 2017 08:22:49 Elan Ruusam�e wrote:
ideally the `config.h` platform defaults should be moved to
configure or dropped at all.
Exactly. Do you feel like writing such a patch?
As for this PR, I am fine with merging it as it is.
Thank you all for working on this!
|
| [ | ||
| case "$withval" in | ||
| yes|no) | ||
| AC_MSG_ERROR([--with-default-mail-command-path=COMMAND requires a command to be specified]) |
Add option to configure to specify the default mail command, if not given falls back to config.h as of now