Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More refined syntax check w/ #AutoIt3Wrapper_AU3Check_Parameters #216

Merged
merged 2 commits into from
Jul 2, 2024

Conversation

vanowm
Copy link

@vanowm vanowm commented Mar 31, 2024

same as #215 but with
ability overwrite settings via #AutoIt3Wrapper_AU3Check_Parameters

w/ #AutoIt3Wrapper_AU3Check_Parameters overwrites
@loganch
Copy link
Owner

loganch commented Apr 11, 2024

Messed with it a little bit and I think there's a small issue that the flags actually include a space, e.g., the flag to enable local var used in global scope is "-w 4", so the comma separation in the initial variable and the regex/logic to parse from the script need to be adjusted.

@vanowm
Copy link
Author

vanowm commented Apr 11, 2024

I don't believe I understand you...which variable and regex you are referring to?

@sven-seyfert
Copy link

Hi @loganch, hi @vanowm 👋 .

I don't believe I understand you...which variable and regex you are referring to?

I guess line 48 is meant by Logan. But I also don't see the problem.

The RegEx pattern (-w-?)\s+([0-9]+) matches the following variants, as far as I can say and understood:

As image (visualization)

grafik

As text form

;~ ----
;~ Okay
;~ ----
#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 -w 3 -w 4 -w 5 -w 6 -w 7

#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 -w    3 -w 4 -w 5 -w 6 -w 7

#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 -w- 3 -w 4 -w 5 -w 6 -w 7

#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 -w-   3 -w 4 -w 5 -w 6 -w 7

;~ --------
;~ Not okay
;~ --------
#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 -w3 -w 4 -w 5 -w 6 -w 7

#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 -w-3 -w 4 -w 5 -w 6 -w 7

#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 w 3 -w 4 -w 5 -w 6 -w 7

#AutoIt3Wrapper_AU3Check_Parameters=-d -w 1 -w 2 w- 3 -w 4 -w 5 -w 6 -w 7

My manual tests for this PR were successful 😀 . But I hope I do not miss something 🤔 ?

Best regards
Sven

@loganch loganch mentioned this pull request Jul 2, 2024
@loganch
Copy link
Owner

loganch commented Jul 2, 2024

No, I was mistaken, merging it now.

@loganch loganch merged commit 9ee9008 into loganch:master Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants