Collect turbinia processor telemetry #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchop
requested changes
May 15, 2024
dftimewolf/lib/utils.py
Outdated
| @@ -17,6 +18,11 @@ | |||
| TOKEN_REGEX = re.compile(r'\@([\w_]+)') | |||
|
|
|||
|
|
|||
| def CalculateRunTime(time_start: float) -> float: | |||
| """Calculates a time delta used for runtime calulcations.""" | |||
There was a problem hiding this comment.
Given all the operations happening, it would be nice to specify which units we're taking in and returnin (e.g. seconds, milliseconds, etc.)
dftimewolf/lib/state.py
Outdated
|
|
||
| total_time = utils.CalculateRunTime(time_start) | ||
| TELEMETRY.LogTelemetry( | ||
| 'total_time', str(total_time), 'core', self.recipe.get('name', 'no_name')) |
There was a problem hiding this comment.
I'd argue that the key here should rather be something like total_time_<module_name> so that we can differentiate the entries per module.
Alternatively - you can also change the 'core' parameter to be core-<module_name>.
There was a problem hiding this comment.
Same comment for the changes in L365
Comment on lines
267
to
282
| # Store profiler telemetry | ||
| telemetry_entry = {} | ||
| for profiler_entry in ( | ||
| self.profiler.getstats()): # pytype: disable=attribute-error | ||
| # pytype: disable=attribute-error | ||
| if isinstance(profiler_entry.code, str): | ||
| method_name = profiler_entry.code | ||
| else: | ||
| method_name = profiler_entry.code.co_name | ||
| if method_name in self.profiler_methods: | ||
| telemetry_entry[method_name] = ( | ||
| f'callcount: {str(profiler_entry.callcount)}, ' | ||
| f'tottime :{str(round(profiler_entry.totaltime * 1000, 10))},' | ||
| f'inlinetime: {str(round(profiler_entry.inlinetime * 1000, 10))}' | ||
| ) | ||
| self.LogTelemetry(telemetry_entry) |
There was a problem hiding this comment.
For readbility, consider extracting this chunk to its own function?
tomchop
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.