Type annotations #411
Merged
Type annotations #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovannt0
previously approved these changes
Jul 18, 2021
giovannt0
pushed a commit
to giovannt0/dftimewolf
that referenced
this pull request
Aug 3, 2021
* pytype annotations * First pass * mypy.ini file * Second pass * Add github action * Fix tests * Update requirements * Add req to pipfile * Fix bad imports * Fix broken test * Strict type checking is stricter * isort config for imports * Python is nice because it's dynamically typed #not * Ignore protobuf files * Remove superfluous params from Github action * Bugfix * Fix cyclic dependency * Fix Github action syntax * Disable cyclic import linter warning * Fix mypy * Add PyYAML types
giovannt0
added a commit
to giovannt0/dftimewolf
that referenced
this pull request
Aug 3, 2021
* pytype annotations * First pass * mypy.ini file * Second pass * Add github action * Fix tests * Update requirements * Add req to pipfile * Fix bad imports * Fix broken test * Strict type checking is stricter * isort config for imports * Python is nice because it's dynamically typed #not * Ignore protobuf files * Remove superfluous params from Github action * Bugfix * Fix cyclic dependency * Fix Github action syntax * Disable cyclic import linter warning * Fix mypy * Add PyYAML types
tomchop
added a commit
that referenced
this pull request
Aug 5, 2021
* Initial commit for metawolf Signed-off-by: Theo Giovanna <[email protected]> * Type annotations (#411) * pytype annotations * First pass * mypy.ini file * Second pass * Add github action * Fix tests * Update requirements * Add req to pipfile * Fix bad imports * Fix broken test * Strict type checking is stricter * isort config for imports * Python is nice because it's dynamically typed #not * Ignore protobuf files * Remove superfluous params from Github action * Bugfix * Fix cyclic dependency * Fix Github action syntax * Disable cyclic import linter warning * Fix mypy * Add PyYAML types * Metawolf part 2 Signed-off-by: Theo Giovanna <[email protected]> * Type annotations (#411) * pytype annotations * First pass * mypy.ini file * Second pass * Add github action * Fix tests * Update requirements * Add req to pipfile * Fix bad imports * Fix broken test * Strict type checking is stricter * isort config for imports * Python is nice because it's dynamically typed #not * Ignore protobuf files * Remove superfluous params from Github action * Bugfix * Fix cyclic dependency * Fix Github action syntax * Disable cyclic import linter warning * Fix mypy * Add PyYAML types * cleanup PR Signed-off-by: Theo Giovanna <[email protected]> * Add missing commands to docs Signed-off-by: Theo Giovanna <[email protected]> * Fix requirements Signed-off-by: Theo Giovanna <[email protected]> * More missing docs Signed-off-by: Theo Giovanna <[email protected]> * ooops Signed-off-by: Theo Giovanna <[email protected]> * Add space for pylint Signed-off-by: Theo Giovanna <[email protected]> * Show current session in show sessions Signed-off-by: Theo Giovanna <[email protected]> * Fix reload boolean Signed-off-by: Theo Giovanna <[email protected]> * Make metawolf testable: migrate to poutput for printing output, and add a test case Signed-off-by: Theo Giovanna <[email protected]> * Add various scenario-based tests to metawolf Signed-off-by: Theo Giovanna <[email protected]> * Bad copy pasta (typo) Signed-off-by: Theo Giovanna <[email protected]> * PR comments (excluding tests) Signed-off-by: Theo Giovanna <[email protected]> * PR comments (tests) Signed-off-by: Theo Giovanna <[email protected]> * Fetch short desc Signed-off-by: Theo Giovanna <[email protected]> * Fix prepare cmd test Signed-off-by: Theo Giovanna <[email protected]> * Remove unused import Signed-off-by: Theo Giovanna <[email protected]> * fix linter et al. Signed-off-by: Theo Giovanna <[email protected]> * Add missing dependencies * Missing deps Signed-off-by: Theo Giovanna <[email protected]> * Missing deps Signed-off-by: Theo Giovanna <[email protected]> * Update deps * fix path Signed-off-by: Theo Giovanna <[email protected]> * forgot one Signed-off-by: Theo Giovanna <[email protected]> Co-authored-by: Thomas Chopitea <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.