Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better critical error handling #397

Merged
merged 4 commits into from
May 12, 2021
Merged

Better critical error handling #397

merged 4 commits into from
May 12, 2021

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented May 11, 2021

Raise CriticalError instead of just calling exit()

@tomchop tomchop requested a review from giovannt0 May 11, 2021 16:38
giovannt0
giovannt0 approved these changes May 12, 2021
View reviewed changes
Copy link
Collaborator

@giovannt0 giovannt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giovannt0 giovannt0 merged commit e8956f7 into log2timeline:main May 12, 2021
@tomchop tomchop deleted the critical_errors branch May 17, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannt0 giovannt0 giovannt0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchop @giovannt0