Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better module import #390

Merged
merged 7 commits into from
May 7, 2021
Merged

Better module import #390

merged 7 commits into from
May 7, 2021

Conversation

tomchop
Copy link
Collaborator

@tomchop tomchop commented May 5, 2021

This change imports modules dynamically - only the modules declared in the recipe will be imported at runtime.

@tomchop tomchop requested a review from Onager May 5, 2021 14:18
@giovannt0 giovannt0 self-requested a review May 5, 2021 14:52
giovannt0
giovannt0 approved these changes May 5, 2021
View reviewed changes
Copy link
Collaborator

@giovannt0 giovannt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Side nit, is there a preferred string formatting method in use in this repo? I see usage of both f'xxx {yyy} zzz' and 'xxx {0:s} zzz'.format(yyy)

@tomchop tomchop merged commit cc94be5 into log2timeline:main May 7, 2021
@tomchop
Copy link
Collaborator Author

tomchop commented May 7, 2021

That's a good point. I opened #391 to move the discussion there.

@tomchop tomchop deleted the better_module_import branch May 7, 2021 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannt0 giovannt0 giovannt0 approved these changes

@Onager Onager Awaiting requested review from Onager

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomchop @giovannt0