change documentation, show clearly how sortBy work with two iteratees #4467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
So I sighed CLA, but jsf-clabot still says I am not. Do I need some additional steps? |
|
Assuming your email that you signed it with matches the one on your commit you might try rebasing and force-pushing to the PR. (or the bot could be hiccuping at the moment) |
|
This kind of doc change doesn't really need a CLA so I'll merge it. We can troubleshoot your CLA on your next PR :D Thanks @theGABS! |
jdalton
added
issue bankruptcy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pull request related to this issue #4376 (Changing documentation for sortBy, so it clearly shows order when sorting by several attributes)