Replacing a regex with a quick character check #3308
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlhunter
commented
Aug 8, 2017
tlhunter
commented
- Checking the 0th position of the string should be quicker than a regular expression
* Checking the 0th position of the string should be quicker than a regular expression
|
|
jdalton
reviewed
Aug 8, 2017
| @@ -25,7 +24,7 @@ const rePropName = RegExp( | |||
| */ | |||
| const stringToPath = memoizeCapped((string) => { | |||
| const result = [] | |||
| if (reLeadingDot.test(string)) { | |||
| if (string.charAt(0) === '.') { | |||
| result.push('') | |||
There was a problem hiding this comment.
Comparing against the char code would be faster.
Something lile
const codeOfDot = '.'.charCodeAt(0)Then later
string.charCodeAt(0) === codeOfDot
|
Closing as inactive. |
falsyvalues
added a commit
that referenced
this pull request
Aug 14, 2017
jdalton
added a commit
that referenced
this pull request
Feb 3, 2018
jdalton
added a commit
that referenced
this pull request
Feb 3, 2018
This was referenced Apr 19, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.