refactor: Prefer first() over get(0)

on vectors for better readability and idiomacy.

lib/src/client/transport/core.rs

@@ -255,7 +255,7 @@ impl TransportState {
  });
  let mut ret = Vec::with_capacity(chunks.len());
  let mut expect_sequence_number = chunks
- .get(0)
+ .first()
  .unwrap()
  .header
  .sequence_header

samples/demo-server/src/methods.rs

@@ -88,7 +88,7 @@ impl callbacks::Method for Boop {
  // Validate input to be a string
  debug!("Boop method called");
  let in1_status = if let Some(ref input_arguments) = request.input_arguments {
- if let Some(in1) = input_arguments.get(0) {
+ if let Some(in1) = input_arguments.first() {
  if let Variant::String(_) = in1 {
  StatusCode::Good
  } else {
@@ -152,7 +152,7 @@ impl callbacks::Method for HelloX {
  // Validate input to be a string
  let mut out1 = Variant::Empty;
  let in1_status = if let Some(ref input_arguments) = request.input_arguments {
- if let Some(in1) = input_arguments.get(0) {
+ if let Some(in1) = input_arguments.first() {
  if let Variant::String(in1) = in1 {
  out1 = Variant::from(format!("Hello {}!", &in1));
  StatusCode::Good

samples/demo-server/src/scalar.rs

@@ -206,7 +206,7 @@ fn add_static_array_variables(server: &mut Server, ns: u16, static_folder_id: &N
  .map(|_| scalar_default_value(*sn))
  .collect::<Vec<Variant>>();
 
- let value_type = values.get(0).unwrap().type_id();
+ let value_type = values.first().unwrap().type_id();
  VariableBuilder::new(&node_id, name, name)
  .data_type(*sn)
  .value_rank(1)
@@ -254,7 +254,7 @@ fn add_dynamic_array_variables(server: &mut Server, ns: u16, dynamic_folder_id:
  let values = (0..10)
  .map(|_| scalar_default_value(*sn))
  .collect::<Vec<Variant>>();
- let value_type = values.get(0).unwrap().type_id();
+ let value_type = values.first().unwrap().type_id();
  VariableBuilder::new(&node_id, name, name)
  .data_type(*sn)
  .value_rank(1)
@@ -285,7 +285,7 @@ fn set_dynamic_timers(server: &mut Server, ns: u16) {
  let values = (0..10)
  .map(|_| scalar_random_value(*sn))
  .collect::<Vec<Variant>>();
- let value_type = values.get(0).unwrap().type_id();
+ let value_type = values.first().unwrap().type_id();
  let _ =
  address_space.set_variable_value_by_ref(&node_id, (value_type, values), &now, &now);
  });

samples/web-client/src/main.rs

@@ -302,7 +302,7 @@ impl OPCUASession {
  if args.len() != 3 {
  return;
  }
- let event_node_id = args.get(0).unwrap();
+ let event_node_id = args.first().unwrap();
  let where_clause = args.get(1).unwrap();
  let select_criteria = args.get(2).unwrap();
 
@@ -322,7 +322,7 @@ impl OPCUASession {
  return;
  }
  // Left and right operands
- let lhs_str = where_parts.get(0).unwrap();
+ let lhs_str = where_parts.first().unwrap();
  let operator = where_parts.get(1).unwrap();
  let rhs_str = where_parts.get(2).unwrap();