Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 style(ui): Confirmation when adding a new topic #3030

Merged
merged 5 commits into from
Jul 13, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented Jun 25, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

在移动端点击将当前会话保存为话题时,会进行弹窗进行二次确认,避免误触

在移动设备上,话题列表中的MoreVertical图标将会始终显示

Upon selecting the option to "Save current conversation as topic" on the mobile terminal, a pop-up window will be displayed for secondary confirmation, thus preventing any potential accidental touches.

In the context of mobile devices, the "MoreVertical" icon will invariably be present within the topic list.

📝 补充信息 | Additional Information

close #2717
photo

topic

Copy link

vercel bot commented Jun 25, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Pro Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (6335be4) to head (59b82e6).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3030      +/-   ##
==========================================
+ Coverage   93.99%   94.13%   +0.14%     
==========================================
  Files         390      392       +2     
  Lines       24314    24372      +58     
  Branches     2675     1799     -876     
==========================================
+ Hits        22853    22943      +90     
+ Misses       1461     1429      -32     
Flag Coverage Δ
app 94.13% <ø> (+0.14%) ⬆️
server 68.85% <ø> (+0.54%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RubuJam
Copy link
Contributor Author

RubuJam commented Jun 25, 2024

@arvinxx Please review

src/features/ChatInput/Topic/index.tsx Outdated Show resolved Hide resolved
Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 13, 2024 5:00am

@arvinxx
Copy link
Contributor

arvinxx commented Jul 11, 2024

新增的按钮不应该用警戒色,需要换成普通的,其他我没问题了

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


The newly added buttons should not use warning colors and need to be replaced with normal ones. I have no problem with the rest.

@arvinxx arvinxx merged commit dc38cd4 into lobehub:main Jul 13, 2024
7 of 8 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @RubuJam ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 13, 2024
### [Version&nbsp;1.4.1](v1.4.0...v1.4.1)
<sup>Released on **2024-07-13**</sup>

#### 💄 Styles

- **ui**: Confirmation when `adding a new topic`.
- **misc**: Add cloud promotion banner.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **ui**: Confirmation when `adding a new topic`, closes [#3030](#3030) ([dc38cd4](dc38cd4))
* **misc**: Add cloud promotion banner, closes [#3194](#3194) ([62db0f8](62db0f8))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RubuJam RubuJam deleted the style/topic branch July 13, 2024 06:50
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 13, 2024
### [Version&nbsp;1.47.1](v1.47.0...v1.47.1)
<sup>Released on **2024-07-13**</sup>

#### 💄 Styles

- **ui**: Confirmation when `adding a new topic`.
- **misc**: Add cloud promotion banner.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **ui**: Confirmation when `adding a new topic`, closes [lobehub#3030](https://github.com/bentwnghk/lobe-chat/issues/3030) ([dc38cd4](dc38cd4))
* **misc**: Add cloud promotion banner, closes [lobehub#3194](https://github.com/bentwnghk/lobe-chat/issues/3194) ([62db0f8](62db0f8))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 16, 2024
* 💄 style(ui): Confirm before opening a new topic

* 💄 style(ui): Always display `MoreVertical` on mobile

* 💄 style(ui): Adjust style of some components

* 💄 style(ui): Adjust the popment of `Popconfirm`

* 💄 style(ui): Adjust the popment of `Popconfirm`
Mingholy pushed a commit to Mingholy/lobe-chat that referenced this pull request Jul 16, 2024
### [Version&nbsp;1.4.1](lobehub/lobe-chat@v1.4.0...v1.4.1)
<sup>Released on **2024-07-13**</sup>

#### 💄 Styles

- **ui**: Confirmation when `adding a new topic`.
- **misc**: Add cloud promotion banner.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **ui**: Confirmation when `adding a new topic`, closes [lobehub#3030](lobehub#3030) ([dc38cd4](lobehub@dc38cd4))
* **misc**: Add cloud promotion banner, closes [lobehub#3194](lobehub#3194) ([62db0f8](lobehub@62db0f8))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
* 💄 style(ui): Confirm before opening a new topic

* 💄 style(ui): Always display `MoreVertical` on mobile

* 💄 style(ui): Adjust style of some components

* 💄 style(ui): Adjust the popment of `Popconfirm`

* 💄 style(ui): Adjust the popment of `Popconfirm`
ipoly pushed a commit to ipoly/lobe-chat that referenced this pull request Jul 29, 2024
### [Version&nbsp;1.4.1](lobehub/lobe-chat@v1.4.0...v1.4.1)
<sup>Released on **2024-07-13**</sup>

#### 💄 Styles

- **ui**: Confirmation when `adding a new topic`.
- **misc**: Add cloud promotion banner.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Styles

* **ui**: Confirmation when `adding a new topic`, closes [lobehub#3030](lobehub#3030) ([dc38cd4](lobehub@dc38cd4))
* **misc**: Add cloud promotion banner, closes [lobehub#3194](lobehub#3194) ([62db0f8](lobehub@62db0f8))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] IOS端浏览器访问-“将当前会话保存为话题”不可用
3 participants