Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: Fixed mobile web page navigation issue with inbox assistant #2693

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

RubuJam
Copy link
Contributor

@RubuJam RubuJam commented May 28, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 🔨 chore
  • ⚡️ perf
  • 📝 docs

🔀 变更说明 | Description of Change

修复移动设备通过会话设置打开默认助手界面后,点击返回跳转至错误页面

A malfunction was identified in the Default Assistant interface, accessible via Session Settings on mobile devices. Upon clicking Back, users were inadvertently directed to an unexpected web page.

📝 补充信息 | Additional Information

此PR为临时举措,具体解决方案见#2633

This PR is a temporary measure. For a concrete solution, see #2633

Copy link

vercel bot commented May 28, 2024

@RubuJam is attempting to deploy a commit to the LobeHub Team on Vercel.

A member of the Team first needs to authorize it.

@lobehubbot
Copy link
Member

👍 @RubuJam

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.96%. Comparing base (1fa160f) to head (f7d105f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2693   +/-   ##
=======================================
  Coverage   93.95%   93.96%           
=======================================
  Files         388      388           
  Lines       24176    24176           
  Branches     1898     1799   -99     
=======================================
+ Hits        22715    22716    +1     
+ Misses       1461     1460    -1     
Flag Coverage Δ
app 93.96% <ø> (+<0.01%) ⬆️
server 68.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx
Copy link
Contributor

arvinxx commented May 28, 2024

修复移动设备上点击请求桌面网站后,自动跳转至https://chat-preview.lobehub.com/

原理是啥?为啥会跳到 chat-preview?

OFFICIAL_URL 不能改,也不能用环境变量。

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Fixed the problem that after clicking on the mobile device to request the desktop website, it will automatically jump to https://chat-preview.lobehub.com/

What is the principle? Why jump to chat-preview?

OFFICIAL_URL cannot be changed, nor can environment variables be used.

@RubuJam
Copy link
Contributor Author

RubuJam commented May 28, 2024

@arvinxx 我上传了一个视频,另外我也还在了解原因

I uploaded a video, and I still know the reason

@arvinxx
Copy link
Contributor

arvinxx commented May 28, 2024

@RubuJam 我试了下似乎只有 Safari 下有这个问题,Chrome 并不会跳到 preview

@lobehubbot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


@RubuJam I tried it and it seems that this problem only occurs under Safari. Chrome will not jump to preview.

@RubuJam
Copy link
Contributor Author

RubuJam commented May 28, 2024

@arvinxx 那这个就很奇怪了

That’s weird

@arvinxx arvinxx marked this pull request as draft May 28, 2024 11:19
@RubuJam RubuJam changed the title 🐛 fix: Fixed jump error when requesting desktop website 🐛 fix: Fixed jump error when requesting mobile website Jun 24, 2024
@RubuJam RubuJam changed the title 🐛 fix: Fixed jump error when requesting mobile website 🐛 fix: Fixed mobile web page jump error Jun 24, 2024
@RubuJam RubuJam marked this pull request as ready for review June 24, 2024 12:15
@RubuJam
Copy link
Contributor Author

RubuJam commented Jul 4, 2024

@arvinxx Please review

Copy link

vercel bot commented Jul 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lobe-chat-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 7, 2024 2:25am

@RubuJam
Copy link
Contributor Author

RubuJam commented Jul 5, 2024

目前已经恢复,我这边build是正常的

It has been restored and my build is normal


@arvinxx Github出故障了,暂时无法构建 https://www.githubstatus.com/incidents/5yx1d67vq9hg

Github server is down and temporarily unable to build

@arvinxx arvinxx changed the title 🐛 fix: Fixed mobile web page jump error 🐛 fix: Fixed mobile web page navigation issue with inbox assistant Jul 7, 2024
@arvinxx arvinxx merged commit 4476a5e into lobehub:main Jul 7, 2024
6 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @RubuJam ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Jul 7, 2024
### [Version&nbsp;1.2.12](v1.2.11...v1.2.12)
<sup>Released on **2024-07-07**</sup>

#### 🐛 Bug Fixes

- **misc**: Fixed mobile web page navigation issue with inbox assistant, support to disable clerk signup with feature flag.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fixed mobile web page navigation issue with inbox assistant, closes [#2693](#2693) ([4476a5e](4476a5e))
* **misc**: Support to disable clerk signup with feature flag, closes [#3126](#3126) ([4ead315](4ead315))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.2.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RubuJam RubuJam deleted the fix branch July 7, 2024 03:03
github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Jul 7, 2024
### [Version&nbsp;1.45.8](v1.45.7...v1.45.8)
<sup>Released on **2024-07-07**</sup>

#### 🐛 Bug Fixes

- **misc**: Fixed mobile web page navigation issue with inbox assistant, support to disable clerk signup with feature flag.

#### 💄 Styles

- **misc**: Update deepseek max token.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Fixed mobile web page navigation issue with inbox assistant, closes [lobehub#2693](https://github.com/bentwnghk/lobe-chat/issues/2693) ([4476a5e](4476a5e))
* **misc**: Support to disable clerk signup with feature flag, closes [lobehub#3126](https://github.com/bentwnghk/lobe-chat/issues/3126) ([4ead315](4ead315))

#### Styles

* **misc**: Update deepseek max token, closes [lobehub#3143](https://github.com/bentwnghk/lobe-chat/issues/3143) ([4a241b9](4a241b9))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants