command: Log the failed command by full name

Commit 4400918 added logging of failed cmd name but it used c->name only. It might be confusing: Debug: 244 105 command.c:644 run_command(): Command 'init' failed with error code -4 User : 245 106 command.c:711 command_run_line(): Debug: 246 107 command.c:644 run_command(): Command 'init' failed with error code -4 The command on line 244 is 'dap init' Use full name of cmd including parents. Change-Id: Iff131ce6454ef70b353ce1bc6d0a480b92820545 Signed-off-by: Tomas Vanek <[email protected]> Reviewed-on: https://openocd.zylin.com/4837 Reviewed-by: Antonio Borneo <[email protected]> Tested-by: jenkins Reviewed-by: Jean-Christian de Rivaz <[email protected]>
lobaro · Jan 27, 2019 · d0eb66f · d0eb66f
1 parent d9cb559
commit d0eb66f
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/helper/command.c b/src/helper/command.c
@@ -642,7 +642,10 @@ static int run_command(struct command_context *context,
  /* we do not print out an error message because the command *should*
  * have printed out an error
  */
- LOG_DEBUG("Command '%s' failed with error code %d", c->name, retval);
+ char *full_name = command_name(c, ' ');
+ LOG_DEBUG("Command '%s' failed with error code %d",
+ full_name ? full_name : c->name, retval);
+ free(full_name);
  }
 
  return retval;