Made verify_paths() stricter. #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ile type. Test existance of FreeRTOSConfig.h
|
Sorry for the delay, this looks good to me. I see we let the CI checks decay a bit - let me fix these failures separately since it's unrelated to your changes. |
|
I merged a fix for the CI failures. If you merge/rebase master it should work now. |
|
Meh not sure what's going on with the nightly build failures. Rather than continue trying to resolve that all here I'll merge as is. As a note for myself in the future, we should probably move away from using nightly in the CI if we're able to do that now. This build failure is an example of why it can cause headache - there's no agreement on whether the lint that broke the build is even a good thing. rust-lang/rust#121708 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure paths have the expected dir/file type. Test existence of FreeRTOSConfig.h