-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove allocator_api feature dependency to allow stable 1.68 #50
Conversation
What changes are coming in 1.68 that make nightly not necessary? I looked for changelog notes (found these but didn't notice anything relevant). Also, I see there was another change which switches the Linux port path - what is this for? |
This feature was stabilized in 1.68. So We can use nightly and Switch the path because the old path no longer exists. |
Sorry I don't see the connection there - as I understand, we need nightly because Also, I think for the Linux change there is some misunderstanding - GCC/Linux isn't present in the FreeRTOS port itself but for the Linux example we use a 3rd party port, in which case you need to change the port base using |
d7cca9c
to
80f824d
Compare
I have reverted the change of path. Although I think the default path should follow the FreeRTOS official practice. I tested the port in Linux which under Maybe I missed something. I haven't found any code in |
You may be right, I'll have to go back and look at it closer when I have time. At first glance it does seem that |
If we decide allocator_api isn't relevant here we should update the README as well. |
I think we can wait until 1.68 stable releases and then we can test there. I did check that I can build successfully when removing the line |
I think so too. |
I believe The |
From my side it looks like stable 1.68 works fine when removing the |
80f824d
to
9e00917
Compare
I have modified it. |
9e00917
to
8e1df9c
Compare
Yep no point in mentioning it now that it's removed. Thanks! |
No description provided.