fix(llm_judge): Fix display issues in qa_browser #3133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-tucker
force-pushed
the
fix-qa-browser
branch
from
aa55dbd
to
c25a32a
Compare
|
@dave-tucker Could you test whether your CSS works for light mode as well? |
The .update method was deprecated in Gradio 4.x which caused the dropdown to show an error. Added a CSS class to set the text color inside colored blocks to be black as the white text on those pastel colors had too little contrast to be easily read. Signed-off-by: Dave Tucker <[email protected]>
dave-tucker
force-pushed
the
fix-qa-browser
branch
from
c25a32a
to
c111c1a
Compare
|
@merrymercy good call. Everything looks fine in light mode, but it did show that the colors used were not consistent between light and dark mode. I've fixed the PR and force pushed my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The .update method was deprecated in Gradio 4.x which caused the dropdown to show an error.
Added a CSS class to set the text color inside colored blocks to be black as the white text on those pastel colors had too little contrast to be easily read.
Before
After
Related issue number (if applicable)
Checks
format.shto lint the changes in this PR.