Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add guidance support for fastchat #3094

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

linkedlist771
Copy link

Why are these changes needed?

With this feature, we can use the guidance to controll fastchat's llm output.

See this issue2481.

Related issue number (if applicable)

issue2481.

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

Feature: weighted shorted queue
I have added guidance support for fastchat.  Now you can use the guidance to control the llm's output once you have make openai server like deployment.
Feature: add docs for guidance integration
@linkedlist771
Copy link
Author

linkedlist771 commented Feb 27, 2024

Here are smoe changes I forget to push in the openai api server part. It is related with the chun.json. I will commit thoese changes as soon as possible.

In my environment, removing `ensure_ascii=False` from the `openai_api_server` resolved a Pydantic error.
@linkedlist771
Copy link
Author

Here are smoe changes I forget to push in the openai api server part. It is related with the chun.json. I will commit thoese changes as soon as possible.

Done

@linkedlist771
Copy link
Author

@merrymercy Hi, can you review this PR?

@kota-iizuka
Copy link

@linkedlist771 @verena-hallitschke
When will pydantic 2 support #3101 be merged? If #3094 still needs work and won't be merged right away, I think it would be better to merge #3101 first.

@linkedlist771
Copy link
Author

This PR has beeen delayed about one month, I am not sure weather the maintainer has seen it yet.

@verena-hallitschke
Copy link

Hi, @infwinston could you please review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants