Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: switch to GitHub Action #142

Merged
merged 14 commits into from
Apr 30, 2020
Merged

CI: switch to GitHub Action #142

merged 14 commits into from
Apr 30, 2020

Conversation

dannypsnl
Copy link
Member

  • independent run coverage, linter, and test
  • linter will only check without breaking test now
  • test on more platforms: macOS, ubuntu. And more Go version: 1.12, 1.13, and 1.14

@dannypsnl dannypsnl requested a review from mewmew April 29, 2020 12:51
@mewmew
Copy link
Member

mewmew commented Apr 29, 2020

Great job! Looks good to me. Would it be possible to have a dedicated run for Build? That way we could have successful build status, but failing test cases.

@mewmew mewmew merged commit 116ce41 into llir:master Apr 30, 2020
@mewmew
Copy link
Member

mewmew commented Apr 30, 2020

I think we need to update the CI script to also clone the repository recursively. At least if we want for it to also test the testcases in llir/testdata.

Currently go test completes very quickly (which means it didn't run all tests):

From https://github.com/llir/llvm/pull/143/checks?check_run_id=631725008

Run go test ./...
go: finding github.com/google/go-cmp v0.3.1
go: finding github.com/kr/pretty v0.1.0
go: finding github.com/kr/text v0.1.0
ok  	github.com/llir/llvm/asm	0.013s
?   	github.com/llir/llvm/asm/enum	[no test files]
?   	github.com/llir/llvm/cmd/l-tm	[no test files]
ok  	github.com/llir/llvm/internal/enc	0.015s
?   	github.com/llir/llvm/internal/gep	[no test files]
ok  	github.com/llir/llvm/internal/natsort	0.002s
?   	github.com/llir/llvm/internal/osutil	[no test files]
ok  	github.com/llir/llvm/ir	0.005s
ok  	github.com/llir/llvm/ir/constant	0.004s
?   	github.com/llir/llvm/ir/enum	[no test files]
ok  	github.com/llir/llvm/ir/metadata	0.004s
ok  	github.com/llir/llvm/ir/types	0.004s
?   	github.com/llir/llvm/ir/value	[no test files]

@mewmew
Copy link
Member

mewmew commented Apr 30, 2020

Also. Now, we can update the build badge of the readme to point to GitHub actions instead of Travis.

@dannypsnl
Copy link
Member Author

dannypsnl commented Apr 30, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants