Enabling system calls hijacking when using Node.js applications - tes… #366
Conversation
|
Can one of the admins verify this patch? |
|
Dear Reviewer, In order to avoid failure tests, I checked out the master and added the proposed changes. In my local machine I have a Node.js application that works on top of the new version of lkl. In this context, I do not understand the messages reported by the testing system. Could you please help? I am looking forward to hearing from you. Thank you in advance and best regards, |
The test error is due to the coding style check reported by a script (scripts/checkpatch.pl). The script reports errors if the submitted patches (commits) does not fulfill the coding style guideline of linux kernel. See more detail in the documents. https://github.com/lkl/linux/blob/master/Documentation/process/submitting-patches.rst#4-style-check-your-changes |
tools/lkl/lib/hijack/hijack.c
Outdated
| int epoll_create(int flags) | ||
| { | ||
| int nRes; | ||
| lkl_printf("lkl: epoll_create\n"); |
There was a problem hiding this comment.
This looks like a debug leftover, lets remove it.
tools/lkl/lib/hijack/hijack.c
Outdated
| @@ -160,6 +160,19 @@ HOOK_FD_CALL(splice) | |||
| HOOK_FD_CALL(vmsplice) | |||
| HOOK_CALL_USE_HOST_BEFORE_START(pipe); | |||
|
|
|||
| HOOK_CALL_USE_HOST_BEFORE_START(accept4); | |||
| int accept4(int fd, struct sockaddr* addr, socklen_t* addrlen, int flags) | |||
There was a problem hiding this comment.
Please use struct sockaddr *addr instead of struct sockaddr* addr to stay consistent with the Linux kernel coding style.
tools/lkl/lib/hijack/hijack.c
Outdated
| @@ -292,6 +305,24 @@ int select(int nfds, fd_set *r, fd_set *w, fd_set *e, struct timeval *t) | |||
| } | |||
|
|
|||
| HOOK_CALL_USE_HOST_BEFORE_START(epoll_create); | |||
| int epoll_create(int flags) | |||
| { | |||
| int nRes; | |||
There was a problem hiding this comment.
Please don't use camelCase variable and function name, to stay consistent with the Linux kernel coding style. For exaple, you can use res or ret. Use a newline to separate variable definition from the function code.
tools/lkl/lib/hijack/hijack.c
Outdated
| { | ||
| int nRes; | ||
| lkl_printf("lkl: epoll_create\n"); | ||
| if(!lkl_running) |
There was a problem hiding this comment.
Use a space between if and (. Again, Linux kernel coding style.
…ted with lkl only Signed-off-by: Octavian Soldea <[email protected]>
c6dc790
to
8b791da
Compare
|
lkl-jenkins: test this please |
|
@lkl-jenkins: test this please |
Hello Octavian (Purdila), Hajime, Dear Reviewers
Following several previous communications, please find enclosed a modification proposed that uses lkl only. A second part, i.e. modifying constants will be added asap.
Best regards,
Octavian Soldea
This change is