Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: access-control: viewers limit #2243

Merged
merged 2 commits into from
Jul 9, 2024
Merged

api: access-control: viewers limit #2243

merged 2 commits into from
Jul 9, 2024

Conversation

gioelecerati
Copy link
Member

What does this pull request do? Explain your changes. (required)

  • Remove rate limit
  • Apply viewer limit to all users
  • If user has a specific limit set, use it
  • If user has a product with a limit, use it
  • If user has neither, use default

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@gioelecerati gioelecerati requested a review from a team as a code owner July 8, 2024 20:17
@vercel Vercel
Copy link

vercel bot commented Jul 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 9:33am

@gioelecerati gioelecerati marked this pull request as draft July 8, 2024 20:26
victorges
victorges approved these changes Jul 8, 2024
View reviewed changes
packages/api/src/controllers/access-control.ts Outdated Show resolved Hide resolved
packages/api/src/controllers/access-control.ts Outdated Show resolved Hide resolved
@gioelecerati gioelecerati marked this pull request as ready for review July 9, 2024 09:30
leszko
leszko approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added 2 comments, but it's mostly to improve my understanding. The PR is good.

packages/api/src/config.js Show resolved Hide resolved
packages/api/src/controllers/access-control.ts Show resolved Hide resolved
@gioelecerati gioelecerati merged commit 48d273f into master Jul 9, 2024
8 checks passed
@gioelecerati gioelecerati deleted the gio/acl/viewers-limit branch July 9, 2024 16:33
@gioelecerati gioelecerati mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

@leszko leszko leszko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gioelecerati @victorges @leszko