Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ui: various fixes and enhancements #2240

Merged
merged 17 commits into from
Jul 11, 2024
Merged

ui: various fixes and enhancements #2240

merged 17 commits into from
Jul 11, 2024

Conversation

suhailkakar
Copy link
Member

@suhailkakar suhailkakar commented Jul 2, 2024 •
edited
Loading

What does this pull request do? Explain your changes. (required)

  • fix: 404 error on stream delete (ENG-2148)
  • fix: display error message for invalid payment card (ENG-2149)
  • ui: add 30 seconds time limit to password reset request

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@suhailkakar suhailkakar requested review from a team as code owners July 2, 2024 07:30
@vercel Vercel
Copy link

vercel bot commented Jul 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 11, 2024 7:48pm

leszko
leszko approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@leszko leszko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @suhailkakar

Added some comments, other than that LGTM

packages/api/src/controllers/user.test.ts Outdated Show resolved Hide resolved
packages/www/components/Sidebar/index.tsx Show resolved Hide resolved
@suhailkakar suhailkakar marked this pull request as draft July 4, 2024 11:21
@suhailkakar suhailkakar changed the title ui/api: various fixes and enhancements ui: various fixes and enhancements Jul 8, 2024
0xcadams
0xcadams requested changes Jul 9, 2024
View reviewed changes
packages/www/components/Sidebar/index.tsx Outdated Show resolved Hide resolved
packages/www/lib/utils/can-send-email.ts Show resolved Hide resolved
@suhailkakar @0xcadams
fix typo
6c7f77f 
Co-authored-by: Chase Adams <[email protected]>
@suhailkakar suhailkakar marked this pull request as ready for review July 10, 2024 14:33
0xcadams
0xcadams reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits but LGTM

packages/www/components/Sidebar/index.tsx Outdated Show resolved Hide resolved
packages/www/lib/utils/can-send-email.ts Show resolved Hide resolved
@suhailkakar
Copy link
Member Author

@0xcadams please let me know, when we can merge this

@0xcadams 0xcadams merged commit ca62f7f into master Jul 11, 2024
8 checks passed
@0xcadams 0xcadams deleted the dashboard-nits-1 branch July 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leszko leszko leszko approved these changes

@0xcadams 0xcadams 0xcadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suhailkakar @leszko @0xcadams