Fix thumbs for direct uploads #2222
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
I'm thinking we may want to add coverage for this in MediaGuard? Unless @victorges you think it should be easy to add a unit test here, I couldn't see an existing one I could piggy back on. |
| thumbnails: !(await isExperimentSubject( | ||
| "vod-thumbs-off", | ||
| req.user?.id, | ||
| )), |
There was a problem hiding this comment.
If you want to have this logic for all assets, might wanna check usages of this createTask function. I know there's at least recordings tasks which are created from cannon.ts
|
re tests: I think we are fine without a test here, it's a really simple logic. I also understood that MediaGuard was supposed to test only the basic stuff for a continuous test, while we test all features like this from E2E tests instead. So maybe those would be better? (probably on |
No description provided.