project: user: create default project id #2163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
60d135d
to
7058730
Compare
5b34aa4
to
a3433e1
Compare
484148f
to
409929b
Compare
b396dbd
to
dcb76d3
Compare
| @@ -1477,4 +1500,51 @@ | |||
| } | |||
| ); | |||
|
|
|||
| app.post( | |||
| "/migrate/userDefaultProject", | |||
| authorizer({ anyAdmin: true }), | |||
Check failure
Code scanning / CodeQL
Missing rate limiting High
| @@ -139,4 +139,47 @@ | |||
| res.json(project); | |||
| }); | |||
|
|
|||
| app.patch("/:id", authorizer({}), async (req, res) => { | |||
Check failure
Code scanning / CodeQL
Missing rate limiting High
| res.end(); | ||
| }); | ||
|
|
||
| app.delete("/:id", authorizer({}), async (req, res) => { |
Check failure
Code scanning / CodeQL
Missing rate limiting High
leszko
requested changes
Jun 7, 2024
There was a problem hiding this comment.
Good work @gioelecerati 🎖️ I really like where it's heading, plus the mung injection. I think it simplified a lot of things.
Added some inline comments, other than that I tried the following:
| Test | Result |
|---|---|
non-admin token /stream/<id> |
🆗 |
non-admin token /stream |
🚫 no projectId included |
non-admin token /asset/<id> |
🆗 |
non-admin token /asset |
🚫 no projectId included |
admin token /stream/<id> |
🚫 no projectId included |
admin token /stream |
🚫 no projectId included |
admin token /asset/<id> |
🚫 no projectId included |
admin token /asset |
🚫 no projectId included |
Could you please check? I think we should always include projectId in the resource. I checked it in the box.
b2b50b4
to
b3b9eac
Compare
victorges
added a commit
that referenced
this pull request
Jun 11, 2024
This reverts commit c39df25.
victorges
added a commit
that referenced
this pull request
Jun 11, 2024
This reverts commit d9fcb78.
victorges
added a commit
that referenced
this pull request
Jun 11, 2024
This reverts commit e34ac4d.
victorges
added a commit
that referenced
this pull request
Jun 11, 2024
This reverts commit eed03f8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do? Explain your changes. (required)
Specific updates (required)
How did you test each of these updates (required)
Does this pull request close any open issues?
Screenshots (optional)
Checklist