api: Add createdByTokenName field to assets #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need a lot of stuff from the request, and now something else (req.token). So let's just send the whole req for simplicity.
The API key ID is basically the ID itself. Let's stop copying it around so much. This is not really used anywhere but to leak tokens lol
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gioelecerati
approved these changes
Feb 1, 2024
| @@ -182,15 +182,15 @@ function parseUrlToDStorageUrl( | |||
| } | |||
|
|
|||
| export async function validateAssetPayload( | |||
| req: Pick<Request, "body" | "user" | "token" | "config">, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to do some analytics on how many assets are being created with API keys or from the dashboard.
Additional changes:
validateAssetPayloadto avoid it growing indefinitelycreatedByTokenIdfrom streams which just increases our leakage risk (API keys IDs are the keys themselves)