Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On a different note, should there an
adpativeStream
mode which includes audio also? I guess it can get confusing. I was thinking a participant leveladaptiveStream
. If any of the video tile of a participant is visible (camera or screen share), audio is also enabled. If none are visible, audio also disabled in this mode?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might make sense for a narrow set of use cases, but also wondering if it's worth the mental overhead to reason about different adaptiveStream modes to support it.
FWIW, the adaptiveStream setting already can be passed in as a config object, so it's not too far fetched to think about
adaptiveStream: { includeAudio: true }
or something along those linesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it will increase cognitive load. Don't think it is worth it.