Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter out default devices #485

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Don't filter out default devices #485

merged 2 commits into from
Oct 26, 2022

Conversation

lukasIO
Copy link
Contributor

@lukasIO lukasIO commented Oct 24, 2022

in order to detect OS Level default switches.

closes #483

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2022

🦋 Changeset detected

Latest commit: 4442387

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
livekit-client Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@davidzhao davidzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@lukasIO lukasIO merged commit 1cc2cab into main Oct 26, 2022
@lukasIO lukasIO deleted the lukas/dont-filter-default branch October 26, 2022 11:39
@github-actions github-actions bot mentioned this pull request Oct 26, 2022
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 5, 2022
* Don't filter out default devices in order to detect OS Level default switches

* changeset
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 5, 2022
* Don't filter out default devices in order to detect OS Level default switches

* changeset
max-b pushed a commit to Invisv-Privacy/client-sdk-js that referenced this pull request Dec 9, 2022
* Don't filter out default devices in order to detect OS Level default switches

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not filter out "default" audio device
2 participants