Fix stuck reconnect #475
Merged
Fix stuck reconnect #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6837e81 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Co-authored-by: David Zhao <[email protected]>
Merged
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* retry initial signal connection * changeset * move retry logic into rtcEngine * make maxJoinAttempts configurable * update changeset * typo * move maxRetries into connectOpts * wip * more logic in engine * remove comment * fix connect logic * don't reject reconnect promise * replace reconnectFuture with event driven logic * changeset * Update src/room/RTCEngine.ts Co-authored-by: David Zhao <[email protected]> * change naming Co-authored-by: David Zhao <[email protected]>
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 5, 2022
* retry initial signal connection * changeset * move retry logic into rtcEngine * make maxJoinAttempts configurable * update changeset * typo * move maxRetries into connectOpts * wip * more logic in engine * remove comment * fix connect logic * don't reject reconnect promise * replace reconnectFuture with event driven logic * changeset * Update src/room/RTCEngine.ts Co-authored-by: David Zhao <[email protected]> * change naming Co-authored-by: David Zhao <[email protected]>
max-b
pushed a commit
to Invisv-Privacy/client-sdk-js
that referenced
this pull request
Dec 9, 2022
* retry initial signal connection * changeset * move retry logic into rtcEngine * make maxJoinAttempts configurable * update changeset * typo * move maxRetries into connectOpts * wip * more logic in engine * remove comment * fix connect logic * don't reject reconnect promise * replace reconnectFuture with event driven logic * changeset * Update src/room/RTCEngine.ts Co-authored-by: David Zhao <[email protected]> * change naming Co-authored-by: David Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onLinelistener to initiate a reconnect attempt if the browser detects that the network status has switched toonlinereconnectFutureand instead overrides existing reconnection attempts when a new call toconnecthappensreconnectFuture) to defer adding tracks while connecting/reconnecting