Add experimental option to pipe attached audio tracks through webaudio API #446
Conversation
🦋 Changeset detectedLatest commit: 405f613 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
src/room/track/RemoteAudioTrack.ts
Outdated
| setAudioContext(audioContext: AudioContext) { | ||
| this.audioContext = audioContext; | ||
| if (this.attachedElements.length > 0) { | ||
| this.setupWebAudio(audioContext, this.attachedElements[0]); |
There was a problem hiding this comment.
if attached to multiple elements, do we only need to handle the first one?
There was a problem hiding this comment.
or would it be a limitation that it only handles a single audio element?
There was a problem hiding this comment.
for webaaudio we only need one element, as we're actually not interested in the element, but rather in the mediastream attached with it. we wouldn't want to pipe the same audio track multiple times into web audio
There was a problem hiding this comment.
but just realised detach logic is still missing...
…o API (livekit#446) * add option to pipe attached audio tracks through webaudio api * use logger * detach logic * reconnect if still attached * set nodes to undefined * cleanup * add method to set additional audionodes that plugin between track and destination * changeset * only reconnect webaudio if needed
…o API (livekit#446) * add option to pipe attached audio tracks through webaudio api * use logger * detach logic * reconnect if still attached * set nodes to undefined * cleanup * add method to set additional audionodes that plugin between track and destination * changeset * only reconnect webaudio if needed
…o API (livekit#446) * add option to pipe attached audio tracks through webaudio api * use logger * detach logic * reconnect if still attached * set nodes to undefined * cleanup * add method to set additional audionodes that plugin between track and destination * changeset * only reconnect webaudio if needed
No description provided.